Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-2677: Remove local accounts message / banner #67

Merged
merged 2 commits into from
Jun 14, 2023
Merged

A0-2677: Remove local accounts message / banner #67

merged 2 commits into from
Jun 14, 2023

Conversation

youPickItUp
Copy link

No description provided.

@youPickItUp youPickItUp requested review from Kocik, deuszx and piotrMocz and removed request for deuszx June 13, 2023 12:20
piotrMocz
piotrMocz reviewed Jun 13, 2023
View reviewed changes
Copy link

@piotrMocz piotrMocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment in code you haven't directly changed :)

packages/page-accounts/src/Accounts/BannerExtension.tsx Outdated Show resolved Hide resolved
@youPickItUp youPickItUp added this pull request to the merge queue Jun 14, 2023
Merged via the queue into alephzero with commit da7d870 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalooc jalooc jalooc approved these changes

@piotrMocz piotrMocz piotrMocz approved these changes

@Marcin-Radecki Marcin-Radecki Awaiting requested review from Marcin-Radecki

@Kocik Kocik Awaiting requested review from Kocik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youPickItUp @piotrMocz @jalooc