-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-2985: Add azero dev azero id integration #80
A0-2985: Add azero dev azero id integration #80
Conversation
…" links when unneeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew, that's a big chunk of refactor 😶 Great work 💪
I've tested the most common paths and all works really nice with good UX. Nevertheless, I think it'd be wise to have a big round of internal testing before public release 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good 👍 Leaving just a couple of nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (from a perspective of an end user). It's not the most beautiful thing but I understand that's not the requirement for azero.dev :P
remove autogenerated |
Adding an account with domain show it:
Adding account to address book as well:
Own accounts either show domain or register link:
Same in account details:
Not own accounts show domain by not register link:
Transfers work and allow searching by primary domain of saved accounts:
You can filter / select validators by domain:
Edit:
Add external link to user domain if exists:
Edit2:
Add domain to block info details signer: