Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-2985: Add azero dev azero id integration #80

Merged
merged 37 commits into from
Sep 11, 2023

Conversation

youPickItUp
Copy link

@youPickItUp youPickItUp commented Aug 23, 2023

Adding an account with domain show it:
image

Adding account to address book as well:
image

Own accounts either show domain or register link:
image

Same in account details:
image
image

Not own accounts show domain by not register link:
image

Transfers work and allow searching by primary domain of saved accounts:
image

You can filter / select validators by domain:
image
image
image
image
image

Edit:
Add external link to user domain if exists:
image

Edit2:
Add domain to block info details signer:
image

packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
packages/react-components/src/InputAddress/index.tsx Outdated Show resolved Hide resolved
packages/react-components/src/InputAddress/index.tsx Outdated Show resolved Hide resolved
packages/react-components/src/InputAddress/index.tsx Outdated Show resolved Hide resolved
packages/react-components/src/InputAddress/index.tsx Outdated Show resolved Hide resolved
packages/react-components/src/InputAddress/index.tsx Outdated Show resolved Hide resolved
@youPickItUp youPickItUp requested a review from jalooc August 29, 2023 11:12
Copy link

@jalooc jalooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, that's a big chunk of refactor 😶 Great work 💪

I've tested the most common paths and all works really nice with good UX. Nevertheless, I think it'd be wise to have a big round of internal testing before public release 😄

packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/page-alliance/package.json Outdated Show resolved Hide resolved
packages/react-components/src/AzeroId.tsx Outdated Show resolved Hide resolved
@youPickItUp youPickItUp requested a review from jalooc September 1, 2023 16:50
Copy link

@jalooc jalooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good 👍 Leaving just a couple of nits.

packages/react-components/src/index.ts Show resolved Hide resolved
packages/apps-config/src/links/azeroId.ts Show resolved Hide resolved
packages/apps-config/src/links/azeroId.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (from a perspective of an end user). It's not the most beautiful thing but I understand that's not the requirement for azero.dev :P

@youPickItUp
Copy link
Author

remove autogenerated package.json changes

@youPickItUp youPickItUp added this pull request to the merge queue Sep 11, 2023
Merged via the queue into alephzero with commit 0129f74 Sep 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants