Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slack notifications channel #99

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update slack notifications channel #99

merged 2 commits into from
Feb 15, 2024

Conversation

Marcin-Radecki
Copy link

No description provided.

Copy link

@youPickItUp youPickItUp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some polkadot mechanism has triggered on new year and it wants all headers updated... Not sure if it's only for their files or all files, but perhaps it would be simplest to roll with it? 😅

We can also try to find where it's coming from - I think @jalooc has some experience with that

@jalooc
Copy link

jalooc commented Feb 6, 2024

We discussed this a longer while ago and the resolution was to remove the eslint rule. I think we should just do it now. Any objections?

@youPickItUp
Copy link

youPickItUp commented Feb 6, 2024

We discussed this a longer while ago and the resolution was to remove the eslint rule. I think we should just do it now. Any objections?

I don't mind, but don't we want to update the files created by polkadot? I'm not sure what sense does changing the copyright year every year make, but there's gotta be something to it if so many people do that... right? 😅

image
image

@jalooc
Copy link

jalooc commented Feb 6, 2024

Oh yeah, we can do that too.

@Marcin-Radecki
Copy link
Author

Let me try to fix in the upstream PR which I plan to do right now. This PR contains only slack channel update so I'll merge it now.

@Marcin-Radecki Marcin-Radecki added this pull request to the merge queue Feb 15, 2024
Merged via the queue into alephzero with commit 280ff9d Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants