Feature/error on details refresh undefined permissions #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zackcl ok NOW it can be reviewed/retested |
zackcl
approved these changes
Feb 29, 2024
zackcl
deleted the
feature/error-on-details-refresh-undefined-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses another small bug unveiled after fixing segments page refresh in #1252, which was caused by a race condition between fetching permissions and fetching segments where if segments fetch finished first, permissions is null.
The permissions object was not being utilized properly though, that thing should be strictly read-only. The conditions currently used to disable those buttons are being determined by segment type / status, not user permissions.