Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning icon when no enabled include lists defined 2 #1907

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

zackcl
Copy link
Collaborator

@zackcl zackcl commented Sep 6, 2024

Resolves #1841, resolves #1838

This PR does the same thing as PR #1892 (will be closed if this is merged), but it includes featureFlagSegmentInclusion instead of hasEnabledIncludeList in the response from the api/flags/paginated endpoint. Also, this PR doesn't require updating the current test cases to avoid failures.

Changes made:

  • Updated the api/flags/paginated endpoint to include featureFlagSegmentInclusion in the response.
  • Updated the selector logic for determining the warning state in feature-flags.selector.ts.
  • Modified this.featureFlagService.fetchFeatureFlags() to this.featureFlagService.fetchFeatureFlags(true) in the FeatureFlagRootSectionCardComponent to ensure that flags are re-fetched from api/flags/paginated whenever the user navigates back to the root page.
  • Updated the warning tooltip message to "No include lists enabled."
  • Updated common-details-participant-list-table.component.html to fix the undefined errors when navigating to the details page.

@zackcl zackcl merged commit be3b112 into dev Sep 9, 2024
14 checks passed
@zackcl zackcl deleted the feature/1841-include-lists-warning2 branch September 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants