add assign mooclet proxy to assignment service #2169
Conversation
danoswaltCL
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7 and
zackcl
danoswaltCL
changed the title
|
@bcb37 this is ready for review but I am asking the Mooclet team folks if sending the "learner" is needed when getting condition. I can see that it will add |
| private assignRandom( | ||
| experiment: Experiment, | ||
| user: ExperimentUser, | ||
| enrollmentCount?: { conditionId: string; userCount: number }[] | ||
| ): ExperimentCondition { |
There was a problem hiding this comment.
Is there a way to keep the return type here?
There was a problem hiding this comment.
yes probably, i can add that back, not sure why removed
| private async getConditionFromMoocletProxy(experiment: Experiment, user: ExperimentUser) { | ||
| const userId = user.id; | ||
|
|
||
| const condition = await this.moocletExperimentService.getConditionFromMoocletProxy(experiment, userId); |
There was a problem hiding this comment.
Do we want to create this variable just to return it?
There was a problem hiding this comment.
we don't have to, I guess I like to be explicit vs saving a couple of characters... it's also slightly easier to debug later if need be, all the data is assembled there in the local scope to spy or log out.
|
|
||
| // public async getVersionForNewLearner(moocletId: number, userId: string) { | ||
| // const endpoint = `/mooclet/${moocletId}/run?learner=${userId}`; | ||
| public async getVersionForNewLearner(moocletId: number, userId: string) { |
There was a problem hiding this comment.
Is the return type (Promise<MoocletVersionResponseDetails>) inferred here?
There was a problem hiding this comment.
i can add a tyep.
|
Got a response and it seems that we not only should send the learner for this /mooclet/:id/run call, but also when sending a "reward", which is not something I was testing. I will need to check that out next week to see what the affect is, but I think we do in fact want what is currently coded up after all. |
This reverts commit 58ff547.
This adds assignment proxy to experimentAssignmentService for Mooclet experiments.
Experiments that are created with a Mooclet assignment algorithm will generate two entities in the db to map the relationship between the Upgrade Experiment entities and its Mooclet counterparts, "MoocletExperimentRef" and "MoocletVersionConditionMap", which is joined to the MoocletExperimentRef document as an array of direct relationships between Mooclet "versions" and UpGrade "conditions".
On
/assign, if a user has not already been enrolled in the mooclet experiment they have been assigned, a call will be proxied to the Mooclet API to be given a new "version" (condition).When fetching a new version, the MoocletExperimentRef will be fetched via UpGrade experimentId to find the condition that this version is mapped to, which is what is returned in the response as normal Upgrade condition assignment.
When this assignment is marked, the user will be enrolled as normal in the UpGrade experiment and subsequent calls to /assign will not reach out to the Mooclet server.
Note! the assignment retrieved from Mooclet for ts_configurable is not constant like it is in upgrade, you could get any of the versions involved on each call until it is marked, so this is something we should discuss.