Refactor getAllExperimentConditions function for proper readability #2171
+351
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppratikcr7
changed the title
VivekFitkariwala
previously requested changes
Jan 23, 2025
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can you check the logic of allWithinSubjectsSites and allWithinSubjectsTargets? It is getting iterated over all filtered experiment.
There was a problem hiding this comment.
Can you also fix the return type of getAllMonitoredDecisionPointLog?
There was a problem hiding this comment.
Can you fix the return type of getFactorialCondition
There was a problem hiding this comment.
allWithinSubjectsSites and allWithinSubjectsTargets are getting iterated on filtered experiments after processing experiment pools.
filteredExperiments = this.processExperimentPools( filteredExperiments, mergedIndividualAssignment, groupEnrollments, experimentUser );
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on adding helper functions for getAllExperimentConditions and reduce the complexity of the code. I have also added comments for better understanding.