This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Chapter markings aren't visible when in full screen #16
Labels
Comments
ViRo3
changed the title
due to poor contrast with black
Chapter markings aren't visible when in full screen
Jan 5, 2022
robert-corlett
added a commit
to robert-corlett/iina
that referenced
this issue
Apr 15, 2022
Fixes CarterLi#16 by adjusting the color of the chapter markers to blue to improve contrast and ensure visibility across both windowed and fullscreen OSC. Only applies to dark mode.
The contrast of the chapter markers in the windowed OSC in either dark or light mode is exceptionally poor, and is not visible in the fullscreen OSD when in dark mode. I propose a change, see commit bc237b1
What do y'all think? |
1 task
CarterLi
added a commit
that referenced
this issue
May 15, 2022
CarterLi
added a commit
that referenced
this issue
May 17, 2022
low-batt
pushed a commit
that referenced
this issue
May 28, 2022
CarterLi
added a commit
that referenced
this issue
Jun 8, 2022
CarterLi
added a commit
that referenced
this issue
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
When the app is windowed, the chapter markings on the playback slider is visible but when in full screen the markings aren't visible
System and IINA version:
Expected behavior:
The markings should be clearly distinct no matter what the background to the OSC is.
Actual behavior:
Markings of chapters disappear when in full screen is OSC fulls over black borders. The markings should be distinct no matter the background of the OSC.
Refer to attached screenshots : OSC with chapters in windowed
OSC with chapters in full screen
How often does this happen?
Always
The text was updated successfully, but these errors were encountered: