Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

Chapter markings aren't visible when in full screen #16

Closed
ViRo3 opened this issue Jan 5, 2022 · 1 comment
Closed

Chapter markings aren't visible when in full screen #16

ViRo3 opened this issue Jan 5, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed priority low

Comments

@ViRo3
Copy link

ViRo3 commented Jan 5, 2022

When the app is windowed, the chapter markings on the playback slider is visible but when in full screen the markings aren't visible

System and IINA version:

  • macOS 12.1 (21C52)
  • IINA 1.2.0 Build 129

Expected behavior:
The markings should be clearly distinct no matter what the background to the OSC is.

Actual behavior:

Markings of chapters disappear when in full screen is OSC fulls over black borders. The markings should be distinct no matter the background of the OSC.

Above

Refer to attached screenshots : OSC with chapters in windowed
OSC with chapters in full screen

  • [*] MPV does not have this problem.

How often does this happen?
Always

@ViRo3 ViRo3 changed the title due to poor contrast with black Chapter markings aren't visible when in full screen Jan 5, 2022
@CarterLi CarterLi added the help wanted Extra attention is needed label Jan 17, 2022
@CarterLi CarterLi added enhancement New feature or request priority low labels Feb 9, 2022
robert-corlett added a commit to robert-corlett/iina that referenced this issue Apr 15, 2022
Fixes CarterLi#16 by adjusting the color of the chapter markers to blue to improve contrast and ensure visibility across both windowed and fullscreen OSC. Only applies to dark mode.
@robert-corlett
Copy link

The contrast of the chapter markers in the windowed OSC in either dark or light mode is exceptionally poor, and is not visible in the fullscreen OSD when in dark mode. I propose a change, see commit bc237b1

  • Adjusted the color of chapter markers to blue when in 'dark' mode, which improves visibility across both windowed and fullscreen contexts.
  • Darkened the color of chapter markers slightly when in 'light' mode to ensure sufficient contrast.

What do y'all think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed priority low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants