Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

HDR doesn't get detected if video has HDR on a secondary video track and SDR on the default track #6

Closed
1 task
AuroraWright opened this issue Dec 10, 2021 · 8 comments
Assignees

Comments

@AuroraWright
Copy link

AuroraWright commented Dec 10, 2021

If you have a mkv file with more than one video track, and the main track is not HDR, even if you switch to the HDR track IINA doesn't activate HDR and it doesn't show up in the inspector. As an example, I tested this with a mkv containing a both a 1080p SDR and a 4K HDR track. When I used mkvtoolnix to change the mkv header to set the 4k video as default, HDR was correctly detected.

System and IINA version:

  • macOS 12.0.1 (16" 2021 macbook pro)
  • IINA IINA plus 1.2.0-13

Expected behavior:
HDR should be also checked for when changing the video track, not just when the file is opened.

Actual behavior:
This doesn't happen currently

Crash report:

mpv log:

Steps to reproduce:

  • MPV does not have this problem.

How often does this happen?

@CarterLi
Copy link
Owner

Yeah. Can you provide a video source for testing?

@CarterLi CarterLi self-assigned this Dec 11, 2021
@AuroraWright
Copy link
Author

The videos I tested this with are blu-ray remuxes so they're very large (70 GB), but here is one of them https://drive.google.com/file/d/1AzOxXsmA21mLKa_uRgwaiwgO6L4VsJPn/view?usp=sharing

@CarterLi
Copy link
Owner

omg. Can you cut it?

iina#3539 (comment)

@AuroraWright
Copy link
Author

omg. Can you cut it?

iina#3539 (comment)

I wasn't sure if you could easily keep HDR but it turns out mkvtoolnix does it: https://drive.google.com/file/d/1EXtsdtB9QkHlhBxSkMVy155fhzJUnXjv/view?usp=sharing I reproduced the issue with this too

@CarterLi
Copy link
Owner

CarterLi commented Dec 11, 2021

Thanks for help ( and your luma3ds project too ) 😄

EDIT: it's still too huge. 3 seconds are enough for testing. I have networking issues accessing google drive and the download speed is very low.

@AuroraWright
Copy link
Author

AuroraWright commented Dec 11, 2021

Okay, made a 5 seconds one and I also uploaded it to OneDrive (see which one downloads better for you)
https://drive.google.com/file/d/1bBa5dyL7CV0iOXAEvuEaJqGx7LlgixqF/view?usp=sharing
https://1drv.ms/u/s!AnCIzvWkmHOmiS6m3db16oVya767?e=VmhYco

CarterLi added a commit that referenced this issue Dec 11, 2021
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
@CarterLi
Copy link
Owner

@AuroraWright
Copy link
Author

Thanks, the issue is fixed!

CarterLi added a commit that referenced this issue Dec 14, 2021
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Jan 19, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Jan 21, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
low-batt pushed a commit that referenced this issue Jan 21, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Feb 18, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Feb 21, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Feb 28, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Apr 23, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
low-batt pushed a commit that referenced this issue Apr 23, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
CarterLi added a commit that referenced this issue Apr 24, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
low-batt pushed a commit that referenced this issue Apr 24, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
low-batt pushed a commit that referenced this issue Apr 27, 2022
Pros: Much easier to detect HDR content, including cases of switching video track, play list. HDR mode for network resources can also be detected.
Cons: Display-P3 will no longer be enabled because MPV doesn't honor mastering display metadata.

Fixes #6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants