Escape NULL terminator in strings with correct glyph #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! I don't have strong opinions on those 2 questions so I'll let others give their input :) |
I usually favor using the glyph directly — most people would investigate an outputted glyph by copy-pasting into Xcode or github.com search, so good to include it as-glyph in source. Just merged Carthage/Carthage#2252 which avoids an instance of the incomplete output fixed with this PR. Thanks for both, and the discovery, and the other work, @iv-mexx 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Carthage/Carthage#2252 (comment)
Two questions:
escapingWhitespaces. Should we rename it or could NULL be considered a Whitespace?U+2400)?@jdhealy