Actually escape whitespace characters instead of quoting the entire string #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
approved these changes
Mar 14, 2017
Sources/Task.swift
Outdated
| @@ -47,12 +47,14 @@ public struct Task { | |||
| } | |||
|
|
|||
| private extension String { | |||
| static let whitespaceRegularExpression = try! NSRegularExpression(pattern: "\\s") | |||
There was a problem hiding this comment.
I'd make this explicitly private. If the visibility of the extension is changed, we still want this to remain an implementation detail.
There was a problem hiding this comment.
Thanks @NachoSoto, addressed in 1e977b3.
|
It doesn't look like we have a test for this. Would you mind adding one? |
|
I've just added the tests. ✨ |
mdiep
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be better than #63.