Update ReactiveSwift to 2.0.0-rc.2 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
force-pushed
the
reactiveswift-2.0-rc
branch
from
b97323a to
5064cf8
Compare
ikesyo
commented
Jul 4, 2017
Sources/Task.swift
Outdated
| @@ -504,20 +504,22 @@ extension Task { | |||
| if terminationStatus == EXIT_SUCCESS { | |||
| // Wait for stderr to finish, then pass | |||
| // through stdout. | |||
| disposable += stderrAggregated | |||
| let disposable = stderrAggregated | |||
There was a problem hiding this comment.
The absence of a replacement for diposable += ... is pretty inconvenient. We always need an extra variable for the use-cases. 😕
There was a problem hiding this comment.
Let's maybe wait on a replacement operator then?
There was a problem hiding this comment.
We can continue to use += operator 😃
ikesyo
force-pushed
the
reactiveswift-2.0-rc
branch
4 times, most recently
from
7148d9d to
1258cc5
Compare
ikesyo
changed the title
ikesyo
force-pushed
the
reactiveswift-2.0-rc
branch
from
1258cc5 to
c1cce91
Compare
mdiep
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.