Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to prevent reaching file name length limit #390

Open
wants to merge 4 commits into
base: cdb
Choose a base branch
from

Conversation

mbektash
Copy link

@mbektash mbektash commented Dec 8, 2016

No description provided.

@javisantana
Copy link
Contributor

cc @rochoa cold you review (I think the test failing is not due to this change)

@rochoa
Copy link
Contributor

rochoa commented Dec 9, 2016

Code LGTM 👍 . Tests failing seems related to connectivity problems between Travis and nodejs.org, making impossible to install the correct Node.js version to run the tests. Let's wait until that problem is solved, and we can validate all tests.

@rochoa
Copy link
Contributor

rochoa commented Dec 12, 2016

Do you mind upgrading your branch with master? We recently fixed some unstable tests.

@mbektash
Copy link
Author

mbektash commented Dec 12, 2016

@rochoa we have been using cdb branch. How is that different from master? What is the cdb for?

@rochoa
Copy link
Contributor

rochoa commented Dec 12, 2016

cdb branch is a stable branch, we merge changes from master into cdb once in a while, usually when we consider master good/tested enough.

I just updated cdb with latest improvements in testing environment/tests. So you can pick the changes from there also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants