Allow tests to be executed against pgbouncer #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgbouncer does not support the `--client-min-messages` option. Actually it fails connections if used like that with this somewhat cryptic message: ``` psql: ERROR: Unsupported startup parameter: options ``` In order to be able to execute tests against pgbouncer port (which is desirable IMO), we either need to remove that option (with little to no impact) or change the lines above to choose the batch API port from the config. Mind that this affects just test setup.
|
Note I did not change the file But I could change my |
dgaubert
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgbouncer does not support the
--client-min-messagesoption. Actuallyit fails connections if used like that with this somewhat cryptic
message:
In order to be able to execute tests against pgbouncer port (which is
desirable IMO), we either need to remove that option (with little to no
impact) or change the lines above to choose the batch API port from the
config.
Mind that this affects just test setup.