Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging redis errors of MapStore #708

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Logging redis errors of MapStore #708

merged 4 commits into from
Oct 28, 2019

Conversation

simon-contreras-deel
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel commented Oct 24, 2019 •
edited
Loading

Related to https://github.com/CartoDB/support/issues/2177

The idea is to put this in production, gather stats and then remove it. Do you think I should do it with a more general-purpose?

@simon-contreras-deel simon-contreras-deel changed the title Logging redis commands of MapStore Logging redis errors of MapStore Oct 25, 2019
@simon-contreras-deel simon-contreras-deel marked this pull request as ready for review October 25, 2019 12:37
dgaubert
dgaubert approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@dgaubert dgaubert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how the entry log is going to be parsed in ELK?

@dgaubert
Copy link
Contributor

Please, don't forget to update the NEWS.md before releasing

@simon-contreras-deel
Copy link
Contributor Author

Finally, I am going to create a new log4j logger in windshaft-carto. The idea is to call it windshaft and it would write a JSON. I don't want to define the full logging thing, so I am going to focus only in this case, but it will be a good example for the full one.

@simon-contreras-deel simon-contreras-deel merged commit 56e9a92 into master Oct 28, 2019
@simon-contreras-deel simon-contreras-deel deleted the better-redis-logging branch October 28, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgaubert dgaubert dgaubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-contreras-deel @dgaubert