Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Remove framework-specific examples #59

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

donmccurdy
Copy link
Member

Removes framework-specific examples from the repository. The dependencies (and necessary dependency updates) required to include three frameworks here are too much. We have framework-specific examples elsewhere in:

Copy link
Contributor

@jmgaya jmgaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job and clean-up 💪

I absolutely agree that repeating templates between repositories feels wrong, as they may get outdated easily, but instead, keeping them all together elsewhere feels much more natural and easier to maintain 😄

Copy link
Collaborator

@padawannn padawannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes but I would like to validate with @srtena first

@srtena
Copy link

srtena commented Jan 8, 2025

Yes, no problem. I also think they aren't necessary and we should focus on the app-templates. Thanks team :)

@donmccurdy donmccurdy requested a review from padawannn January 8, 2025 15:24
@donmccurdy donmccurdy force-pushed the chore/rm-framework-examples branch from 86e9c9f to 47ac22d Compare January 8, 2025 15:37
@donmccurdy donmccurdy dismissed padawannn’s stale review January 8, 2025 15:47

Requested review was done.

@donmccurdy donmccurdy merged commit c7cb6fd into main Jan 8, 2025
4 checks passed
@donmccurdy donmccurdy deleted the chore/rm-framework-examples branch January 8, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants