Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL filters while downloading a dataset #165

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

dgaubert
Copy link
Contributor

Add 'sql_query', 'add_geom', and 'is_geography' parameters to allow adding SQL filters while downloading a dataset

@dgaubert dgaubert marked this pull request as ready for review April 9, 2020 16:19
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok. We need to change the version in setup.py and conf.py

Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wondering why tests are failing (stuck again) which is slowing down development.

Yet we need to test the whole feaure in staging as much as needed.

@dgaubert
Copy link
Contributor Author

I've tested the whole feature in staging. You can try the following: CartoDB/cartoframes#1604 (comment) and using the credentials from any user in staging

@dgaubert dgaubert merged commit b5fe930 into master Apr 14, 2020
@dgaubert dgaubert deleted the dgaubert/ch58107/add-sql-filter-to-do-datasets branch April 14, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants