fix: react warning

Workaround to fix a react warning on chrome
CartoDB · Mar 19, 2021 · 1680e11 · 1680e11
1 parent 3920d65
commit 1680e11
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## 1.0.0-rc.2 (2021-03-12)
 - Add improved htmlForFeature in skeleton [#215](https://github.com/CartoDB/carto-react-template/pull/215)
 - Fix immutable/serializable checks for redux middleware in skeleton [#216](https://github.com/CartoDB/carto-react-template/pull/216)
+- Fix general React warning on SharedArrayBuffer [#218](https://github.com/CartoDB/carto-react-template/pull/218)
 
 ## 1.0.0-rc.1 (2021-03-11)
 - Add cypress e2e tests in CI [#194](https://github.com/CartoDB/carto-react-template/pull/194)

diff --git a/template-sample-app/template/public/index.html b/template-sample-app/template/public/index.html
@@ -21,7 +21,10 @@
 
     <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,600;1,400;1,600&display=swap" rel="stylesheet">
     <link href="https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,300;0,400;0,500;0,600;1,300;1,400;1,500;1,600&display=swap" rel="stylesheet">
-
+    <script>
+      // see https://github.com/facebook/react/issues/20829
+      if (!crossOriginIsolated) SharedArrayBuffer = ArrayBuffer;
+    </script>
     <script type="text/javascript" src="%PUBLIC_URL%/supportedBrowsers.js"></script>
     <script type="text/javascript">
       var browserSupported = browserRegex.test(navigator.userAgent);

diff --git a/template-skeleton/template/public/index.html b/template-skeleton/template/public/index.html
@@ -21,7 +21,10 @@
 
     <link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,600;1,400;1,600&display=swap" rel="stylesheet">
     <link href="https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,300;0,400;0,500;0,600;1,300;1,400;1,500;1,600&display=swap" rel="stylesheet">
-
+    <script>
+      // see https://github.com/facebook/react/issues/20829
+      if (!crossOriginIsolated) SharedArrayBuffer = ArrayBuffer;
+    </script>
     <script type="text/javascript" src="%PUBLIC_URL%/supportedBrowsers.js"></script>
     <script type="text/javascript">
       var browserSupported = browserRegex.test(navigator.userAgent);