Skip to content

Commit

Permalink
toggle viewportFilter prop to true by default (#209)
Browse files Browse the repository at this point in the history
  • Loading branch information
AdriSolid authored Mar 11, 2021
1 parent c5334c7 commit 98bb5f6
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion docs/guides/02_page_layer_widgets.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ Replace the text `Hello World` with:
column={STORES_SOURCE_COLUMNS.REVENUE}
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
></FormulaWidget>
/>
<Divider />
Expand Down
3 changes: 0 additions & 3 deletions template-sample-app/template/src/components/views/Kpi.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ function Kpi() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onTotalRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -95,7 +94,6 @@ function Kpi() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onRevenueByStateWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -109,7 +107,6 @@ function Kpi() {
operation={AggregationTypes.COUNT}
column='revenue'
ticks={[10e6, 50e6, 10e7, 50e7, 75e7, 1e9, 2e9]}
viewportFilter
/>

<Divider />
Expand Down
2 changes: 0 additions & 2 deletions template-sample-app/template/src/components/views/Tileset.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ function Tileset() {
operation={AggregationTypes.SUM}
formatter={numberFormatter}
onError={onTotalFareAmountWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -90,7 +89,6 @@ function Tileset() {
operation={AggregationTypes.COUNT}
column='aggregated_total'
ticks={[10, 100, 1e3, 1e4, 1e5, 1e6]}
viewportFilter
/>

<Divider />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ function StoresList() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onTotalRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -65,7 +64,6 @@ function StoresList() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onRevenuePerTypeWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -80,7 +78,6 @@ function StoresList() {
column='revenue'
ticks={[1200000, 1300000, 1400000, 1500000, 1600000, 1700000, 1800000]}
onError={onStoresByRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand Down

1 comment on commit 98bb5f6

@vercel
Copy link

@vercel vercel bot commented on 98bb5f6 Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.