Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: local UserMenuLogin to manage Login button #144

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

VictorVelarde
Copy link
Contributor

@VictorVelarde VictorVelarde commented Dec 9, 2020

Related to CartoDB/carto-react#44

This allows more flexibility (eg. custom styling in the app)

@vercel
Copy link

vercel bot commented Dec 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/hdzca6kxn
✅ Preview: https://cra-template-carto-git-refactor-use-local-login-btn.carto-frontend.vercel.app

Copy link
Contributor

@neokore neokore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM

@VictorVelarde VictorVelarde merged commit c06d402 into master Dec 9, 2020
@VictorVelarde VictorVelarde deleted the refactor-use-local-login-btn branch December 9, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants