Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard interactivity on mobile - add pickingRadius to layers #191

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

AdriSolid
Copy link
Contributor

There was a hard interaction on mobile when trying to click on layers, especially point type. Added pickingRadius to all layers.

For: https://app.clubhouse.io/cartoteam/story/126895/qa-hard-interactivity-on-mobile

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #126895: QA - Hard interactivity on mobile.

@vercel
Copy link

vercel bot commented Feb 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/kgddzj1rb
✅ Preview: https://cra-template-carto-git-fix-ch126895hard-interactivity-on-mobile.carto-frontend.vercel.app

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just add a line to the changelog and we're ready to go

@AdriSolid AdriSolid force-pushed the fix/ch126895/hard-interactivity-on-mobile branch from ae3ed4b to 6c856c7 Compare February 5, 2021 16:16
@AdriSolid AdriSolid merged commit 702df02 into master Feb 5, 2021
@VictorVelarde VictorVelarde deleted the fix/ch126895/hard-interactivity-on-mobile branch February 5, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants