Fix layer generator with 2nd layer #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already added to the view.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/DzJ8pp8Y1Ct47DSXpXUg5w2TQU62 |
|
This pull request has been linked to Clubhouse Story #137053: Fix layer generator with 2nd layer. |
VictorVelarde
changed the title
VictorVelarde
suggested changes
Mar 8, 2021
* Fixed imports from @carto/react/redux * Removed newlines on imports end
VictorVelarde
deleted the
feature/ch137053/fix-layer-generator-with-2nd-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added splitted logic to add layer in the useEffect when the source is already added to the view.
When the source is already added in a view, the layer that we want to attach to the view isn't being added. Using splitted files for injecting the code, we can fix this case.
From ch137053