Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle viewportFilter prop to true by default #209

Merged
merged 7 commits into from
Mar 11, 2021
Merged

toggle viewportFilter prop to true by default #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8556f8
refactor: adapt code to carto-react multipackages
VictorVelarde Mar 6, 2021
936be50
doc: adapt guides to carto-react multipackages
VictorVelarde Mar 6, 2021
14fd167
refactor: adapt hygen templates to carto-react multipackages
VictorVelarde Mar 6, 2021
5406673
fix: viewportFilter prop as true by default
AdriSolid Mar 9, 2021
eb1f1fd
docs: update with viewportFilter prop as true
AdriSolid Mar 9, 2021
bc97547
merge master
AdriSolid Mar 11, 2021
8a9c1a2
Merge branch 'master' into multi-package-lib-viewport-filter-as-true
AdriSolid Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/02_page_layer_widgets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ Replace the text `Hello World` with:
column={STORES_SOURCE_COLUMNS.REVENUE}
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
></FormulaWidget>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/>

<Divider />

Expand Down
3 changes: 0 additions & 3 deletions template-sample-app/template/src/components/views/Kpi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ function Kpi() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onTotalRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -95,7 +94,6 @@ function Kpi() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onRevenueByStateWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -109,7 +107,6 @@ function Kpi() {
operation={AggregationTypes.COUNT}
column='revenue'
ticks={[10e6, 50e6, 10e7, 50e7, 75e7, 1e9, 2e9]}
viewportFilter
/>

<Divider />
Expand Down
2 changes: 0 additions & 2 deletions template-sample-app/template/src/components/views/Tileset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ function Tileset() {
operation={AggregationTypes.SUM}
formatter={numberFormatter}
onError={onTotalFareAmountWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -90,7 +89,6 @@ function Tileset() {
operation={AggregationTypes.COUNT}
column='aggregated_total'
ticks={[10, 100, 1e3, 1e4, 1e5, 1e6]}
viewportFilter
/>

<Divider />
Expand Down
3 changes: 0 additions & 3 deletions template-sample-app/template/src/components/views/stores/StoresList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ function StoresList() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onTotalRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -65,7 +64,6 @@ function StoresList() {
operation={AggregationTypes.SUM}
formatter={currencyFormatter}
onError={onRevenuePerTypeWidgetError}
viewportFilter
/>

<Divider />
Expand All @@ -80,7 +78,6 @@ function StoresList() {
column='revenue'
ticks={[1200000, 1300000, 1400000, 1500000, 1600000, 1700000, 1800000]}
onError={onStoresByRevenueWidgetError}
viewportFilter
/>

<Divider />
Expand Down