Cleanup templates & pin deck.gl 8.4.10 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/4yvGoYt2iSQVJ7j7szwrTH9ncUXD |
AdriSolid
suggested changes
Mar 11, 2021
| if (!user) { | ||
| return <UserMenuLogin />; | ||
| return null; |
There was a problem hiding this comment.
@AdriSolid I don't have a preference. Is there any official recommendation on that?
There was a problem hiding this comment.
I saw that we return null in several components, for me we can leave it like this 👍
VictorVelarde
force-pushed
the
cleanup-templates
branch
from
db3349b to
4884f4c
Compare
Remove code for geocoderWidget, isoline and Login button in the header
VictorVelarde
force-pushed
the
cleanup-templates
branch
from
4884f4c to
b77fb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup on both templates