Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from carto-python in CARTOframes #1090

Closed
alrocar opened this issue Oct 10, 2019 · 3 comments
Closed

Remove warnings from carto-python in CARTOframes #1090

alrocar opened this issue Oct 10, 2019 · 3 comments
Assignees

Comments

@alrocar
Copy link
Contributor

alrocar commented Oct 10, 2019

No description provided.

@simon-contreras-deel
Copy link
Contributor

We are already filtering some messages from carto-python:

from warnings import filterwarnings
filterwarnings("ignore", category=FutureWarning, module="carto")

We need to filter others messages that are not FutureWarning ones, but:

warnings.warn('xxx)

@alrocar
Copy link
Contributor Author

alrocar commented Oct 14, 2019

We used FutureWarnings for APIs in carto-python that are not public and we didn't want them to be used by other people (other than us).

So, for this case, in CARTOframes it's fine to silence FutureWarnings. In carto-python they still make sense.

About the rest of the warnings, I'd consider to remove them from the code (ideally substitute them by a logger).

@simon-contreras-deel
Copy link
Contributor

Ok, I have created CartoDB/carto-python#154 to remove the comment that is being shown in CARTOframes. Also, I added a comment in the CARTOframes one to remove the related filterwarnings

@Jesus89 Jesus89 closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants