ignore carto python warnings #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-contreras-deel
changed the title
|
Auto acceptance 🍏
|
alasarr
reviewed
Oct 15, 2019
| @@ -9,6 +9,9 @@ | |||
| from ...utils.geom_utils import setting_value_exception | |||
| from ...utils.columns import normalize_name | |||
|
|
|||
| from warnings import filterwarnings | |||
There was a problem hiding this comment.
Is that still necessary after removing warnings in CARTO Python?
There was a problem hiding this comment.
Yes, it is. In this case, to get the info about datasets from a CARTO account (we need to get the privacy), we are using a non public API. In the carto-python code we are raising a FutureWarning warning about that. This is what we are filtering here.
There was a problem hiding this comment.
By the way, we have some of them spread by the CARTOframes code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a part of #1090
CR and merge CartoDB/carto-python#154 first.
Then, I will remove the(done)filterwarningsfromapi_contextfile