Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Context API: Credentials + Client Architecture #661

Closed
12 tasks done
simon-contreras-deel opened this issue May 13, 2019 · 2 comments · Fixed by #866
Closed
12 tasks done

Refactor Context API: Credentials + Client Architecture #661

simon-contreras-deel opened this issue May 13, 2019 · 2 comments · Fixed by #866
Assignees
Labels
refactor version: 1.0 Mandatory or nice to have features for 1.0 release

Comments

@simon-contreras-deel
Copy link
Contributor

simon-contreras-deel commented May 13, 2019

in this doc we decided to refactor the internal architecture to support:

  • Different environments of execution (local/APIClient and analysis/PGClient)
  • Allow OAuth integration, with the token refresh mechanism

So basically these are the tasks to achieve the refactor:

  • Create client classes Client Architecture #833
    • BaseClient
    • APIClient: contains sql_client, copy_client, batch_client
  • Refactor Dataset to instantiate and use a client Decoupling clients from Dataset #831
  • New credentials
    • Refactor Credentials (username, api_key, base_url)
    • using new credentials
  • Usingn Credentials instead of Context
    • Use Credentials instead of Context in Dataset
    • Use Credentials instead of Context in Source
    • Use Credentials instead of Context in Layer
    • Use Credentials instead of Context in Map
    • Use Credentials instead of Context in Kuviz classes
    • Use Credentials instead of Context in clients

@simon-contreras-deel simon-contreras-deel added Triple Integration 🔱 version: 1.0 Mandatory or nice to have features for 1.0 release labels May 13, 2019
@Jesus89 Jesus89 added this to the [1.0] Refactor Auth/Data API milestone Jun 24, 2019
@Jesus89 Jesus89 changed the title Context changes Finish Context API Jun 25, 2019
@Jesus89 Jesus89 changed the title Finish Context API Refactor Context API: Credentials + Client Architecture Jul 5, 2019
@simon-contreras-deel
Copy link
Contributor Author

Depends on #831

@simon-contreras-deel
Copy link
Contributor Author

simon-contreras-deel commented Jul 10, 2019

From this comment #832 (comment)

And a naming suggestion: I know we were using creds beforehand, but from now on I'd prefer not abbreviating public API variable names, even more when they have a related class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor version: 1.0 Mandatory or nice to have features for 1.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants