Credentials class refactor #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 17, 2019
simon-contreras-deel
changed the title
simon-contreras-deel
changed the title
andy-esch
reviewed
Jul 17, 2019
andy-esch
reviewed
Jul 17, 2019
houndci-bot
reviewed
Jul 17, 2019
andy-esch
approved these changes
Jul 17, 2019
|
@andy-esch Your work was and is awesome! This is the easy part |
alrocar
reviewed
Jul 18, 2019
There was a problem hiding this comment.
Late to the party
Just a suggestion, we have some code in carto-python to get the username from the base_url it might be useful
| if isinstance(credentials, Credentials): | ||
| return cls(credentials.api_key, credentials.username, credentials.base_url, credentials.session) | ||
|
|
||
| raise ValueError('`credentials` must a Credentials class instance') |
There was a problem hiding this comment.
Thanks!
There was a problem hiding this comment.
Done in #850
alrocar
reviewed
Jul 18, 2019
| with open(config_file or _DEFAULT_PATH, 'r') as f: | ||
| credentials = json.load(f) | ||
|
|
||
| return cls(credentials.get('api_key'), credentials.get('username')) |
There was a problem hiding this comment.
Also this makes the saved credentials not to work in on-premises environments, right?
There was a problem hiding this comment.
Good catch, it is a bug
There was a problem hiding this comment.
Done in #850
|
It is not late! We can do the stuff in the "main PR" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the Credentials class
The first step of #661
In order to avoid a huge PR review like the last one, I am going to create several like this one. The objective is to allow you to check the structure or the idea since the tests are not going to be green. Then, in the main PR (using
feature/credentials-refactor) we will see all together.If you see a better way, please let me know