Support uploading DataFrames with non-ascii texts in Python 2 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the test I have added fails also for Python 3 because it also checks that you can pass encoded attributes (as bytes string). |
houndci-bot
reviewed
Sep 17, 2019
|
So, to be clear: as a bonus point, we now support non only (unicode) strings such as |
jgoizueta
changed the title
|
Thanks! Let's put PR in the |
|
I would like to merge #974 first, to have some test before that. Also, we are going to have some conflicts and it would be easier to solve here than there |
|
Removing the |
# Conflicts: # cartoframes/data/dataset/registry/dataframe_dataset.py # test/data/dataset/test_dataset.py
simon-contreras-deel
approved these changes
Sep 25, 2019
Acceptance ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1000
The fix I propose here accumulates the csv data in unicode form and encodes it only at the end.
Attributes for non-ascii test can be passed as unicode or encoded as bytes, so that simple strings
'...'containing utf-8 characters will work both in Python 2 and 3. Explicit unicode stringu'...'will also work.