Download #1050
Merged
Download #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 3, 2019
alrocar
suggested changes
Oct 7, 2019
|
|
||
| def _download_query(project, dataset, table, limit=None, offset=None): | ||
| full_table_name = '`{}.{}.{}`'.format(project, dataset, table) | ||
| query = 'SELECT * FROM {}'.format(full_table_name) |
There was a problem hiding this comment.
We will use this for both downloading a plain dataset or a geographies dataset. I'd like to be sure of the geometry format downloaded and written in the CSV.
Could we add a test to make sure that we can read/upload to CARTO the geometry in the downloaded CSV file for a geography table? (or any other type of test that you think it might be interesting for this case)
There was a problem hiding this comment.
The geometry is saved as WKT as string in the file
"POLYGON((-4.22608307660106 43.3126868301895, ...))"
We could use a carto-do-public-data for that, but I would not really like to make a tests end to end against big query and carto.
(still thinking about it)
simon-contreras-deel
force-pushed
the
feature/do-bq-download
branch
from
f8643de to
09d64f4
Compare
alrocar
suggested changes
Oct 8, 2019
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
alrocar
reviewed
Oct 8, 2019
|
Acceptance 🍏 Let's address my last comment (about ™️ ) and this is ready to merge. |
simon-contreras-deel
force-pushed
the
feature/do-bq-download
branch
from
558617f to
c43c434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves https://github.com/CartoDB/data-observatory/issues/189