Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isolines range parameter, fix doc #1078

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Rename isolines range parameter, fix doc #1078

merged 2 commits into from
Oct 9, 2019

Conversation

jgoizueta
Copy link
Contributor

Fixes #1077

@jgoizueta jgoizueta requested a review from elenatorro October 9, 2019 11:15
@jgoizueta jgoizueta changed the title Raname isolines range parameter, fix doc Rename isolines range parameter, fix doc Oct 9, 2019
elenatorro
elenatorro approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@elenatorro elenatorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@jgoizueta
Merge branch 'develop' into fix/isolines_range
7b3f654 
# Conflicts:
#	cartoframes/data/services/isolines.py
@jgoizueta jgoizueta merged commit 4902289 into develop Oct 9, 2019
@jgoizueta jgoizueta deleted the fix/isolines_range branch October 9, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenatorro elenatorro elenatorro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Isolines range parameter should be plural
2 participants
@jgoizueta @elenatorro