Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1079 integrate subscriptions #1087

Merged
merged 58 commits into from
Oct 15, 2019
Merged

1079 integrate subscriptions #1087

merged 58 commits into from
Oct 15, 2019

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Oct 10, 2019 •
edited
Loading

Solves #1079

  • Add Catalog().subscriptions method
  • Create Subscriptions class
  • Create SubscriptionInfo class
  • Add Dataset.get(id).subscribe method
  • Add Dataset.get(id).subscription_info method
  • Add Geography.get(id).subscribe method
  • Add Geography.get(id).subscription_info method
  • Add/Update tests
  • Add subscription form (for the notebook)
  • Move fetch_subscriptions to observatory/utils
  • Connect GET /do/subscriptions form carto-python
  • Connect POST /do/subscriptions form carto-python
  • Connect GET /do/subscription_info form carto-python

@Jesus89 Jesus89 self-assigned this Oct 10, 2019
houndci-bot
houndci-bot reviewed Oct 10, 2019
View reviewed changes
test/data/observatory/test_catalog.py Outdated Show resolved Hide resolved
test/data/observatory/repository/test_geography_repo.py Show resolved Hide resolved
cartoframes/data/observatory/utils.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/utils.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/geography.py Show resolved Hide resolved
cartoframes/data/observatory/entity.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Show resolved Hide resolved
cartoframes/data/observatory/catalog.py Outdated Show resolved Hide resolved
@Jesus89 Jesus89 marked this pull request as ready for review October 10, 2019 14:57
@Jesus89 Jesus89 mentioned this pull request Oct 10, 2019
Merged
3 tasks
@Jesus89 Jesus89 force-pushed the 1079-integrate-subscriptions branch from 7e6caad to 3cd7c29 Compare October 10, 2019 15:02
@Jesus89 Jesus89 force-pushed the 1079-integrate-subscriptions branch from f5dc5ac to beb420f Compare October 15, 2019 13:24
@Jesus89 Jesus89 force-pushed the 1079-integrate-subscriptions branch from beb420f to 48e569f Compare October 15, 2019 13:34
jgoizueta
jgoizueta approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@jgoizueta jgoizueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 LGTM

@Jesus89 Jesus89 merged commit 68a3fbf into develop Oct 15, 2019
@Jesus89 Jesus89 deleted the 1079-integrate-subscriptions branch October 15, 2019 13:49
simon-contreras-deel
simon-contreras-deel reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some details

test/data/observatory/repository/test_dataset_repo.py Show resolved Hide resolved
cartoframes/data/observatory/repository/dataset_repo.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@simon-contreras-deel simon-contreras-deel simon-contreras-deel left review comments

@jgoizueta jgoizueta jgoizueta approved these changes

Assignees

@jgoizueta jgoizueta

@Jesus89 Jesus89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jesus89 @alrocar @jgoizueta @simon-contreras-deel @houndci-bot @alasarr