Add Country.categories and Category.geographies properties

[esloho]

Closes #1038

I added the missing methods and then I realized we could always use get_all for those properties so I did a bit of cleaning in code and tests ✨

[alrocar]

✨

[alrocar]

Acceptance 🍊

I've tested the whole list of methods in the original issue and I found a couple of missing ones. Let me know if we should add them:

• Category.get('demographics').countries
• Not sure about this, but properties that are actually a FK are returned as an ID instead of the class instance. Examples (not a comprehensive list I guess). I'd say this is not a big deal and in any case I'd open a separate issue in case we want to support that:
  • Dataset.get('od_acs_1f614ee8').geography
  • Variable.get('poverty_b698f5ff').dataset
  • Geography.get('carto-do-public-data.tiger.geography_usa_countyclipped_2015').country

[alasarr]

Hi, it'd be great if get method for CatalogList should work with slug too.

Dataset.get(<dataset_id>).variables.get().

If we do that we can say that at everypart we can find by slug or id.

[esloho]

• Category.get('demographics').countries

A category has no countries nor direct relation with them, so I understood that was a nested filter use case. You should do:

catalog.category('demographics').countries

However, if we want to have the first option as well, I'll add it. (I already talked to Aroa last week about the fact that we seem to always have 2 ways of doing things, and it's not good.)

• Not sure about this, but properties that are actually a FK are returned as an ID instead of the class instance. Examples (not a comprehensive list I guess). I'd say this is not a big deal and in any case I'd open a separate issue in case we want to support that:

  • Dataset.get('od_acs_1f614ee8').geography
  • Variable.get('poverty_b698f5ff').dataset
  • Geography.get('carto-do-public-data.tiger.geography_usa_countyclipped_2015').country

We discussed this a couple of weeks ago and decided (at least for the moment) to have all FK properties returning the id (but rename them to geography instead of geography_id in the API). The idea was to have it return the whole objects eventually. Should we address this now?

[alrocar]

We discussed this a couple of weeks ago and decided (at least for the moment) to have all FK properties returning the id (but rename them to geography instead of geography_id in the API). The idea was to have it return the whole objects eventually. Should we address this now?

Sorry, it's just I was running the full acceptance cycle and I wasn't aware we decided that 😊

However, if we want to have the first option as well, I'll add it. (I already talked to Aroa last week about the fact that we seem to always have 2 ways of doing things, and it's not good.)

Let's do that validation work with @newLadyAga

@esloho are you going to address this in this PR or in a different one?

[esloho]

Hi, it'd be great if get method for CatalogList should work with slug too.

Done @alasarr !!

[alasarr]

Working! and added to the demo!