Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alasarr/feature 1031 datasets by geom #1112

Merged
merged 10 commits into from
Oct 23, 2019
Merged

Alasarr/feature 1031 datasets by geom #1112

merged 10 commits into from
Oct 23, 2019

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Oct 18, 2019

Solves #1031

houndci-bot
houndci-bot reviewed Oct 18, 2019
View reviewed changes
cartoframes/data/observatory/repository/repo_client.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/repository/repo_client.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/dataset.py Show resolved Hide resolved
cartoframes/data/observatory/catalog.py Outdated Show resolved Hide resolved
cartoframes/data/observatory/catalog.py Outdated Show resolved Hide resolved
@Jesus89 Jesus89 self-assigned this Oct 21, 2019
@Jesus89 Jesus89 marked this pull request as ready for review October 23, 2019 07:10
@Jesus89
Copy link
Member Author

Jesus89 commented Oct 23, 2019

This PR adds RTree as a dependency, and it seems that this is causing the tests to fail

OSError: Could not find libspatialindex_c library file

@Jesus89
Copy link
Member Author

Jesus89 commented Oct 23, 2019

From the geopandas doc:

rtree (optional; spatial index to improve performance and required for overlay operations; interface to libspatialindex)

And also:

rtree does not provide wheels.

This is a problem now because pip does not install completely RTree (it requires extra OS-dependant packages for libspatialindex). So the temporary solution is to remove the dependency, and in the future add the recommendation in the docs conda install rtree.

@Jesus89 Jesus89 merged commit a66a09f into develop Oct 23, 2019
@Jesus89 Jesus89 deleted the alasarr/feature-1031-datasets-by-geom branch October 23, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees

@Jesus89 Jesus89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jesus89 @houndci-bot @alasarr @esloho