Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viz layer examples #1159

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Update viz layer examples #1159

merged 7 commits into from
Nov 7, 2019

Conversation

makella
Copy link
Contributor

@makella makella commented Nov 5, 2019

PR to update some examples with new features.

@makella makella self-assigned this Nov 5, 2019
@makella makella requested a review from Jesus89 November 6, 2019 19:52
@makella
Copy link
Contributor Author

makella commented Nov 6, 2019

@Jesus89 please review!

as mentioned above, this PR does some updates to the Visualization Layer examples:

  • adds the range_min and range_max parameters to the color/size continuous layer examples - - adds an isoline layer example
  • adds the isoline layer to examples.json

why oh why do I fail again! :/

thanks!!

Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note: I'm not sure about adding a widget to select the range in the isolines_layer example, because the user can select one "ring" but this is implemented just to render all the ranges together.

@makella
Copy link
Contributor Author

makella commented Nov 7, 2019

good point! i thought the same thing... should we remove widget=true from the example then?

@makella makella merged commit d5b3860 into develop Nov 7, 2019
@Jesus89 Jesus89 deleted the docs/update-viz-layer-examples branch November 8, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants