-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix COPY data types issues #1190
Conversation
… using the row modifies the type of the data
❤️Love this one! Bugs like these are maybe the most annoying! Beyond the small refactor suggestion, I don't see any recommended changes. Most of it is over my head unless I spend more time thinking through it. |
94daac5
to
1a968af
Compare
1a968af
to
af2f93e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
About tests, are we adding a e2e test to check Inifinity and NaN are properly uploaded/downloaded? Same for 0,0 coordinates.
We have just unit tests for that. I'll add a couple of e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Acceptance 🍏 |
Fixes #784.
This PR contains important fixes related to uploading and downloading data types 🎉
int
and another withfloat
it assumes that the row it typefloat
so it will add yourint
column data asfloat
causing a non-deterministic bug. Now the iteration is made using the index of the row, so the final type of the value is the correct one.numpy
types np.nan, np.inf and -np.inf.dtypes
topgtypes
andpgtypes
todtypes
conversion: using PostgreSQL types instead: https://www.postgresql.org/docs/7.4/datatype.html. Usingpgtype
allows a better mapping for the DataFrame types. The PG types aliases have been added too (int4, float8, etc).NaN
andnull
in the DB.null
,NaN
,Infinite
,-Infinite
values from the CARTO table.POINT(0 0)
.