Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enrichment aggregation and filters #1196

Merged
merged 20 commits into from
Nov 14, 2019

Conversation

simon-contreras-deel
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel commented Nov 13, 2019

Solves: #1174, #1197 and a part of #1183

  • enrichment
  • tests
  • filters
  • tests
  • reference
  • examples

@simon-contreras-deel simon-contreras-deel marked this pull request as ready for review November 13, 2019 19:51
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'm going to run the examples as an acceptance test.


set_default_credentials('YOUR_USER_NAME', 'YOUR_API_KEY')
set_default_credentials(Credentials.from_file())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be used set_default_credentials() instead

@Jesus89 Jesus89 merged commit 5bb904a into develop Nov 14, 2019
@Jesus89 Jesus89 deleted the fix-and-docs-enrichment-aggregation branch November 14, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants