Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guide] Discover data guide #1239

Merged
merged 17 commits into from
Nov 28, 2019
Merged

[Guide] Discover data guide #1239

merged 17 commits into from
Nov 28, 2019

Conversation

alrocar
Copy link
Contributor

@alrocar alrocar commented Nov 25, 2019

Closes #996

@alrocar alrocar self-assigned this Nov 25, 2019
@alrocar alrocar changed the title [Guide] Discover data notebook [Guide] Discover data guide Nov 27, 2019
@alrocar
Copy link
Contributor Author

alrocar commented Nov 27, 2019

http://cd-reference-enrichment-catalog.developers.carto-staging.com/developers/cartoframes/guides/Explore-the-Data-Observatory-catalog/

Pending stuff:

  • Would be nice having a scroll in the dataframe and Dataset, Variable prints. I don't think we should cut them (doing a head or ellipsis), since the whole purpose of this guide is understanding the available data in the Catalog.
  • Still have to extract the map as an external frame and include it with an iframe.

@alrocar alrocar removed their assignment Nov 27, 2019
@alrocar alrocar requested a review from elenatorro November 27, 2019 09:02
<td>carto-do.ags.demographics_sociodemographic_usa...</td>
<td>INTEGER</td>
<td>Population in Group Quarters (2019A)</td>
<td>carto-do.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix this in our markdown. The subscription contract is an auto generated HTML. What I would to is to take an screenshot from the notebook and use it here, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, forgot about that 👍

<td>carto-do.ags.demographics_sociodemographic_usa...</td>
<td>INTEGER</td>
<td>Population in Group Quarters (2019A)</td>
<td>carto-do.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image path is not correct and it's not rendering

<td>carto-do.ags.demographics_sociodemographic_usa...</td>
<td>INTEGER</td>
<td>Population in Group Quarters (2019A)</td>
<td>carto-do.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding a new utility class named u-vertical-scroll. Please add it in the table, next to the "dataframe" class (I'll add this information in the guidelines asap)




[<Variable.get('HINCYMED65_310bc888')> #'Median Household Income: Age 65-74 (2019A)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code is also quite long. Do you think it'd be ok to ✂️cut ✂️it a bit, and have something like:

[<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
...
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',]

Another option would be to put this inside a <div> with the u-vertical-scroll class (the same we'll be using in the tables), but that might require more adjustments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I prefer the scroll thing, I'll add it. Thanks!

@alrocar
Copy link
Contributor Author

alrocar commented Nov 27, 2019

summoning @makella in case you are available for doing some proof-reading, grammar or redaction fixes/suggestions this week 🙏

Copy link
Contributor

@elenatorro elenatorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elenatorro
Copy link
Contributor

As discussed in the meeting, let's merge them to develop and check the guides all together in a final review ✨ awesome work!!!

@elenatorro elenatorro merged commit a6d73fc into develop Nov 28, 2019
@elenatorro elenatorro deleted the 996_discover_data branch November 28, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc - Guides] - Discover Data
2 participants