-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Guide] Discover data guide #1239
Conversation
…artoframes into 996_discover_data
… 996_discover_data
Pending stuff:
|
<td>carto-do.ags.demographics_sociodemographic_usa...</td> | ||
<td>INTEGER</td> | ||
<td>Population in Group Quarters (2019A)</td> | ||
<td>carto-do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix this in our markdown. The subscription contract is an auto generated HTML. What I would to is to take an screenshot from the notebook and use it here, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, forgot about that 👍
<td>carto-do.ags.demographics_sociodemographic_usa...</td> | ||
<td>INTEGER</td> | ||
<td>Population in Group Quarters (2019A)</td> | ||
<td>carto-do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image path is not correct and it's not rendering
<td>carto-do.ags.demographics_sociodemographic_usa...</td> | ||
<td>INTEGER</td> | ||
<td>Population in Group Quarters (2019A)</td> | ||
<td>carto-do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding a new utility class named u-vertical-scroll
. Please add it in the table, next to the "dataframe" class (I'll add this information in the guidelines asap)
|
||
|
||
|
||
[<Variable.get('HINCYMED65_310bc888')> #'Median Household Income: Age 65-74 (2019A)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This piece of code is also quite long. Do you think it'd be ok to ✂️cut ✂️it a bit, and have something like:
[<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
...
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',
<Variable.get('HINCYMED55_1a269b4b')> #'Median Household Income: Age 55-64 (2019A)',]
Another option would be to put this inside a <div>
with the u-vertical-scroll
class (the same we'll be using in the tables), but that might require more adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I prefer the scroll thing, I'll add it. Thanks!
f262e1f
to
aa1398e
Compare
summoning @makella in case you are available for doing some proof-reading, grammar or redaction fixes/suggestions this week 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
As discussed in the meeting, let's merge them to develop and check the guides all together in a final review ✨ awesome work!!! |
Closes #996