Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement __getitem__ in CDF #1245

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Implement __getitem__ in CDF #1245

merged 4 commits into from
Nov 26, 2019

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Nov 26, 2019

Fix #1236

alasarr
alasarr suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@alasarr alasarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests?

@Jesus89 Jesus89 merged commit a7aaf85 into develop Nov 26, 2019
@Jesus89 Jesus89 deleted the 1236-cdf-operations branch November 26, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alasarr alasarr alasarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CartoDataFrame returning GeoDataFrame when it shouldn't
2 participants
@Jesus89 @alasarr