Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Quickstart conflicts #1335

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Fix Quickstart conflicts #1335

merged 2 commits into from
Dec 11, 2019

Conversation

elenatorro
Copy link
Contributor

We discovered some errors after merging last guides review in the quickstart guide.

@elenatorro elenatorro requested a review from cmongut December 11, 2019 08:14
cmongut
cmongut approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@cmongut cmongut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elenatorro elenatorro merged commit 919f643 into develop Dec 11, 2019
@elenatorro elenatorro deleted the fix/quickstart-conflicts branch December 11, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmongut cmongut cmongut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenatorro @cmongut