-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add viz default helpers #1432
Add viz default helpers #1432
Conversation
I'm still trying to understand how the components are loaded as part of a style while at the same time not part of the style but that's my own thing to sort through! Here are some comments/questions after taking a look through:
There seem to be a couple of different ways to do this, so maybe I am missing something! I also don't really understand why things like
I'm gonna keep working with this new stuff to understand it better.. |
Hi 👋, I have updated the ticket description with the changes from the last meeting. |
Note: update examples cc @Jesus89 |
I have added an example in the PR to test this: |
Fix hover click behaviour
As we've talked, after this is ready for merge let's add it and review doc related stuff in this issue #1419 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #1430
PoC implementation of default values and default helpers.