Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a suitable error when trying to visualise a GeoDataFrame with multiple geometries #1541

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Raise a suitable error when trying to visualise a GeoDataFrame with multiple geometries #1541

merged 3 commits into from
Feb 14, 2020

Conversation

josemazo
Copy link
Contributor

@josemazo josemazo requested a review from Jesus89 February 13, 2020 18:37
@josemazo
Copy link
Contributor Author

Ready for re-CR!

Jesus89
Jesus89 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Nice tests! 😄

@Jesus89 Jesus89 merged commit c33a107 into develop Feb 14, 2020
@Jesus89 Jesus89 deleted the josema/ch58603/better_error_for_gdf_multigeom_type branch February 14, 2020 17:03
@Jesus89 Jesus89 mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus89 Jesus89 Jesus89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemazo @Jesus89