Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DODataset to download a dataset from DO #1594

Conversation

dgaubert
Copy link
Contributor

@dgaubert dgaubert commented Mar 13, 2020

Please, I need an early review.

Still pending changes in carto-python to add limit and order_by.

@dgaubert dgaubert marked this pull request as ready for review March 23, 2020 17:56
@dgaubert dgaubert requested a review from rafatower March 26, 2020 16:19
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd take advantage to remove old code.

…d-to' of github.com:CartoDB/cartoframes into dgaubert/ch61421/integrate-do-client-in-to-dataframe-and-to
@dgaubert dgaubert requested a review from rafatower March 27, 2020 09:06
@dgaubert
Copy link
Contributor Author

@rafatower, maybe we want to remove the class BigQueryClient as it seems unused from now on...

@dgaubert
Copy link
Contributor Author

Ok, by removing unused method I need to make the ultimate sacrifice. 😥

@rafatower
Copy link
Contributor

Yeah, sure, if the class is not used anymore, delete it and related tests!

Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Off-topic: the DO repository objects are the ones we should replace in CF's to grab from DO API instead of old rails endpoints. I'll create an issue for that.

@rafatower rafatower changed the base branch from develop to release/1.0.2 April 2, 2020 12:07
@dgaubert dgaubert merged commit 9d37c17 into release/1.0.2 Apr 2, 2020
@Jesus89 Jesus89 deleted the dgaubert/ch61421/integrate-do-client-in-to-dataframe-and-to branch October 15, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants