Fixed Google geocoding #1600
Merged
Fixed Google geocoding #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google geocoder executes using the client's API key and thus doesn't have a defined quota + API key on the dataservices-api server (the available quota obtained using
cdb_dataservices_client.cdb_service_quota_info()is alwaysnull).The behavior of
cdb_dataservices_client.cdb_service_quota_info()cannot be changed to avoid breaking existing client implementations so this check must be done in the client side (CARTOframes in this case).Acceptance steps:
google(using Superadmin for example)google_maps_api_keyfield for the user (only needed if you want to see the actual result for the geocoding, otherwise the geocoding will return an error)Related to https://github.com/CartoDB/support/issues/2451