Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused BigQueryClient and related tests #1602

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

dgaubert
Copy link
Contributor

No description provided.

@dgaubert dgaubert requested a review from rafatower March 27, 2020 14:02
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy piece! 💃

@dgaubert
Copy link
Contributor Author

Apparently, we do have clients using this class, let's stand by this PR until we have a clearer view how to deprecate this class

@cmongut
Copy link
Contributor

cmongut commented Mar 27, 2020

Yeap, some customers wanted to visualise their DO datasets and we gave them a workaround that uses this private client. We hope we can get rid of it soon.

@Jesus89
Copy link
Member

Jesus89 commented Mar 31, 2020

Hi, I have added the do-not-merge tag until we release the v1.0.2. Then, I'll remove it :)

@Jesus89
Copy link
Member

Jesus89 commented Apr 1, 2020

OK, branch release/1.0.2. Removing the tag

@Jesus89
Copy link
Member

Jesus89 commented Jun 17, 2020

We need to provide a way to get the BigQuery credentials in the API. So blocking this until we have that feature.

@Jesus89 Jesus89 removed the blocked label Oct 6, 2020
@Jesus89 Jesus89 changed the base branch from dgaubert/ch61421/integrate-do-client-in-to-dataframe-and-to to develop October 6, 2020 12:54
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time has come 🔥

@Jesus89 Jesus89 merged commit 3a744da into develop Oct 6, 2020
@Jesus89 Jesus89 deleted the remove-big-query-client branch October 6, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants