Format attribute for widgets, popups and legends [ch60845] #1626

neokore · 2020-04-28T16:06:11Z

Related to https://app.clubhouse.io/cartoteam/story/60845/allow-to-format-attributes

houndci-bot · 2020-04-28T16:06:29Z

cartoframes/assets/src/bundle.js

-      const options = { format, config, dynamic };
+      const formatString = legend.format;
+      const formatFunc = formatString
+        ? (value) => format$1(value, formatString)


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2020-04-28T16:06:29Z

cartoframes/assets/src/bundle.js

+            padding = length < width ? new Array(width - length + 1).join(fill) : "";
+
+        // If the fill character is "0", grouping is applied after padding.
+        if (comma && zero) value = group(padding + value, padding.length ? width - valueSuffix.length : Infinity), padding = "";


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2020-04-28T16:06:29Z

cartoframes/assets/src/bundle.js

+          // Break the formatted value into the integer “value” part that can be
+          // grouped, and fractional or exponential “suffix” part that is not.
+          if (maybeSuffix) {
+            i = -1, n = value.length;


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2020-04-28T16:06:29Z

cartoframes/assets/src/bundle.js

+      else if (!formatTypes[type]) precision === undefined && (precision = 12), trim = true, type = "g";
+
+      // If zero fill is specified, padding goes after sign and before digits.
+      if (zero || (fill === "0" && align === "=")) zero = true, fill = "0", align = "=";


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2020-04-28T16:06:30Z

cartoframes/assets/src/bundle.js

+      if (type === "n") comma = true, type = "g";
+
+      // The "" type, and any invalid type, is an alias for ".12~g".
+      else if (!formatTypes[type]) precision === undefined && (precision = 12), trim = true, type = "g";


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2020-04-28T16:06:31Z

cartoframes/assets/src/bundle.js

+        + this.symbol
+        + (this.zero ? "0" : "")
+        + (this.width === undefined ? "" : Math.max(1, this.width | 0))
+        + (this.comma ? "," : "")


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2020-04-28T16:06:32Z

cartoframes/assets/src/bundle.js

+        + this.sign
+        + this.symbol
+        + (this.zero ? "0" : "")
+        + (this.width === undefined ? "" : Math.max(1, this.width | 0))


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2020-04-28T16:06:32Z

cartoframes/assets/src/bundle.js

+        + this.align
+        + this.sign
+        + this.symbol
+        + (this.zero ? "0" : "")


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2020-04-28T16:06:32Z

cartoframes/assets/src/bundle.js

+    return this.fill
+        + this.align
+        + this.sign
+        + this.symbol


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2020-04-28T16:06:33Z

cartoframes/assets/src/bundle.js

+  FormatSpecifier.prototype.toString = function() {
+    return this.fill
+        + this.align
+        + this.sign


Misleading line break before '+'; readers may interpret this as an expression boundary.

Jesus89

You could install a linter locally (in VS) to avoid Hound messages for issues with the linter in JS.
It seems that tests for map, widgets, legends, and popups are failing / not updated.

Jesus89 · 2020-04-29T06:17:26Z

It seems that the linter issue is only with the bundle because of the new dependency d3/format. So we must exclude the bundle from the linter check.

houndci-bot · 2020-04-29T06:55:17Z

cartoframes/assets/src/legends.js

-    const options = { format, config, dynamic };
+    const formatString = legend.format;
+    const formatFunc = formatString
+      ? (value) => format(value, formatString)


Misleading line break before '?'; readers may interpret this as an expression boundary.

VictorVelarde · 2020-04-29T14:28:41Z

cartoframes/viz/widgets/histogram_widget.py

@@ -1,7 +1,8 @@
 from ..widget import Widget


-def histogram_widget(value, title=None, description=None, footer=None, read_only=False, buckets=20, weight=1):
+def histogram_widget(value, title=None, description=None, footer=None, read_only=False,
+                     buckets=20, weight=1):


why this line CR into 2 lines?

This is to avoid too long line warning

VictorVelarde · 2020-04-29T14:30:56Z

The python side look good to me. Let's see if we can get travis to pass

neokore · 2020-04-29T20:04:07Z

Pushed changes for Hound and Travis CI.

neokore · 2020-04-30T12:15:04Z

Travis forced to rebuild and now it passes. A ✔️ for this?

VictorVelarde · 2020-05-06T12:00:43Z

examples/popups/popup_titles_and_format.ipynb

    "    popup_hover=[\n",
-    "        popup_element('name', 'Country', 'population')\n",
+    "        popup_element('name', 'City'),\n",
+    "        popup_element('pop_max', title='Rounded population', format=',.2r')\n",


LGTM. I'm gonna ping here @manmorjim as he's interested in popup and formatting. It looks like using d3.format on both CF and web-sdk could be nice combination

VictorVelarde

New additions on format LGTM.

…/cartoframes into feature/ch60845/format-attribute

neokore added 3 commits April 23, 2020 14:48

Format number attribute (WIP)

9e9046b

Format widget values (WIP)

0529e26

Format attribute for popups and legends [ch60845]

38b98ec

neokore requested review from VictorVelarde, Jesus89 and jesusbotella April 28, 2020 16:06

houndci-bot reviewed Apr 28, 2020

View reviewed changes

Jesus89 reviewed Apr 29, 2020

View reviewed changes

Ignore bundle for JSHint (HoundCI)

653e362

houndci-bot reviewed Apr 29, 2020

View reviewed changes

Allow terniary line break

f1b85fd

VictorVelarde reviewed Apr 29, 2020

View reviewed changes

Fix tests

9fd6442

neokore marked this pull request as ready for review April 30, 2020 11:28

neokore added 2 commits May 5, 2020 21:09

Fix format attribute for legends and update examples

0f7365a

Add format to tooltip example

469defc

VictorVelarde reviewed May 6, 2020

View reviewed changes

VictorVelarde approved these changes May 6, 2020

View reviewed changes

neokore and others added 8 commits May 6, 2020 20:42

Default legend and default popup with examples [ch60845]

4bfa8e8

Update formula widget example

467642c

Merge branch 'feature/ch60845/format-attribute' of github.com:CartoDB…

f3dc0b5

…/cartoframes into feature/ch60845/format-attribute

AirShip to v2.3.2-rc.2

22b30db

Merge branch 'feature/ch60845/format-attribute' of github.com:CartoDB…

e49a7ca

…/cartoframes into feature/ch60845/format-attribute

Fix formula widget example

74955b0

Refactor formatter internal naming

b6028fa

Fix default legend type detection

f779905

Review examples

071945b

Jesus89 approved these changes May 12, 2020

View reviewed changes

Jesus89 merged commit 7e0e8a4 into develop May 12, 2020

Jesus89 deleted the feature/ch60845/format-attribute branch May 12, 2020 07:01

Jesus89 mentioned this pull request May 14, 2020

Implement format attribute #826

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Format attribute for widgets, popups and legends [ch60845] #1626

Format attribute for widgets, popups and legends [ch60845] #1626

neokore commented Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

houndci-bot Apr 28, 2020

Jesus89 left a comment

Jesus89 commented Apr 29, 2020

houndci-bot Apr 29, 2020

VictorVelarde Apr 29, 2020

neokore Apr 29, 2020

VictorVelarde commented Apr 29, 2020

neokore commented Apr 29, 2020

neokore commented Apr 30, 2020

VictorVelarde May 6, 2020

VictorVelarde left a comment

Format attribute for widgets, popups and legends [ch60845] #1626

Format attribute for widgets, popups and legends [ch60845] #1626

Conversation

neokore commented Apr 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jesus89 left a comment

Choose a reason for hiding this comment

Jesus89 commented Apr 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VictorVelarde commented Apr 29, 2020

neokore commented Apr 29, 2020

neokore commented Apr 30, 2020

Choose a reason for hiding this comment

VictorVelarde left a comment

Choose a reason for hiding this comment