Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download dataset example and rename its folder #1634

Merged
merged 3 commits into from
May 12, 2020
Merged

Add download dataset example and rename its folder #1634

merged 3 commits into from
May 12, 2020

Conversation

cmongut
Copy link
Contributor

@cmongut cmongut commented May 11, 2020

No description provided.

@cmongut cmongut requested a review from Jesus89 May 11, 2020 10:47
Jesus89
Jesus89 approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice example! 😄

In the notebook, the title ## Apply a standard filter when downloading the dataset appears twice (for visualization and download)

@cmongut
Copy link
Contributor Author

cmongut commented May 12, 2020

@Jesus89 the title changes a bit. Instead of "Apply a standard filter..." it says "Apply a spatial filter..."

If it's not clear, we could give a second thought to those titles

@Jesus89 Jesus89 merged commit 31390f5 into develop May 12, 2020
@Jesus89 Jesus89 deleted the do_download_example branch May 12, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus89 Jesus89 Jesus89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmongut @Jesus89