Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read null geoms from carto #1637

Merged
merged 3 commits into from
May 19, 2020
Merged

Fix read null geoms from carto #1637

merged 3 commits into from
May 19, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented May 18, 2020 •
edited
Loading

Fixes https://github.com/CartoDB/support/issues/2525

Geom NULL values where not properly detected and converted, so PG '__null' values were not converted to None. This PR fixes the issue.

@Jesus89 Jesus89 requested a review from cmongut May 18, 2020 11:26
cmongut
cmongut approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@cmongut cmongut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jesus89 Jesus89 merged commit 923f617 into develop May 19, 2020
@Jesus89 Jesus89 deleted the fix-read-carto-null-geom branch May 19, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmongut cmongut cmongut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jesus89 @cmongut