Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open "Learn more" link in another window #1647

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Open "Learn more" link in another window #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e769ba8
Open footer link in another window
Jesus89 Jun 12, 2020
7ce6aab
Improve API keys message
Jesus89 Jun 12, 2020
63381b8
Update publish examples
Jesus89 Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cartoframes/assets/templates/viz/footer.html.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="map-footer">
<span>Crafted with ♥ and CARTOframes | <a href="https://carto.com/developers/cartoframes/">Learn more</a></span>
<span>Crafted with ♥ and CARTOframes | <a href="https://carto.com/developers/cartoframes/" target="_blank">Learn more</a></span>
</div>
5 changes: 3 additions & 2 deletions cartoframes/viz/kuviz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ def _create_maps_api_keys(self, layers):
)
log.info(
'The map has been published. '
'The "{0}" Maps API key with value "{1}" is being used for these datasets {2}. '
'You can manage your API keys on your account.'.format(key_name, key_value, private_tables_names))
'The "{0}" Maps API key with value "{1}" is being used for these datasets: {2}. '
'You can manage your API keys on your account.'.format(
key_name, key_value, ', '.join(['"{}"'.format(name) for name in private_tables_names])))
return key_value

return DEFAULT_PUBLIC
Expand Down
2 changes: 1 addition & 1 deletion examples/publish_and_share/publish_visualization_gdf.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"The map has been published. The \"cartoframes_0a8a065b2cc026c5c33ee3dc269afcf1\" Maps API key with value \"YTAEiju-Utii8mgtERiEkA\" is being used for these datasets ['table_name']. You can manage your API keys on your account.\n"
"The map has been published. The \"cartoframes_0a8a065b2cc026c5c33ee3dc269afcf1\" Maps API key with value \"YTAEiju-Utii8mgtERiEkA\" is being used for these datasets: \"table_name\". You can manage your API keys on your account.\n"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/publish_and_share/publish_visualization_layout.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"The map has been published. The \"cartoframes_997c05771fd4e0916de49826722e51cd\" Maps API key with value \"7rj9ftFsOKUjSotnygh2jg\" is being used for these datasets ['private_table']. You can manage your API keys on your account.\n"
"The map has been published. The \"cartoframes_997c05771fd4e0916de49826722e51cd\" Maps API key with value \"7rj9ftFsOKUjSotnygh2jg\" is being used for these datasets: \"private_table\". You can manage your API keys on your account.\n"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/publish_and_share/publish_visualization_private_table.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"The map has been published. The \"cartoframes_997c05771fd4e0916de49826722e51cd\" Maps API key with value \"7rj9ftFsOKUjSotnygh2jg\" is being used for these datasets ['private_table']. You can manage your API keys on your account.\n"
"The map has been published. The \"cartoframes_997c05771fd4e0916de49826722e51cd\" Maps API key with value \"7rj9ftFsOKUjSotnygh2jg\" is being used for these datasets: \"private_table\". You can manage your API keys on your account.\n"
]
},
{
Expand Down