Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Layout publication issue #1654

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Fix Layout publication issue #1654

merged 4 commits into from
Jun 25, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Jun 24, 2020

I have added more tests regarding publication for both Layout and Map.

@Jesus89 Jesus89 requested a review from josemazo June 24, 2020 07:02
josemazo
josemazo approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@josemazo josemazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... once the 3.5 tests are fixed 😆

@Jesus89
Copy link
Member Author

Jesus89 commented Jun 24, 2020

Python 3.5 is the new Python 2.7 :S

@josemazo
Copy link
Contributor

Totally

@Jesus89 Jesus89 merged commit a14adae into develop Jun 25, 2020
@Jesus89 Jesus89 deleted the jarroyo/ch86701/public-cartoframes-kuviz-maps-with-layout branch June 25, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemazo josemazo josemazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jesus89 @josemazo